Skip to content

fix(AppConfig): Mark EuroOffice jwt_secret as sensitive - #63306

Closed
solracsf wants to merge 1 commit into
masterfrom
fix/eurooffice-jwt-secret-sensitive
Closed

fix(AppConfig): Mark EuroOffice jwt_secret as sensitive#63306
solracsf wants to merge 1 commit into
masterfrom
fix/eurooffice-jwt-secret-sensitive

Conversation

@solracsf

@solracsf solracsf commented Aug 17, 2026

Copy link
Copy Markdown
Member

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@solracsf
fix(AppConfig): Mark EuroOffice jwt_secret as sensitive
8ee3d2e 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added this to the Nextcloud 35 milestone Aug 17, 2026
@solracsf
solracsf requested a review from a team as a code owner August 17, 2026 08:35
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 17, 2026
@solracsf
solracsf requested review from Altahrim, CarlSchwan, icewind1991 and sorbaugh and removed request for a team August 17, 2026 08:35
@solracsf

solracsf commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@solracsf

solracsf commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@solracsf
solracsf enabled auto-merge August 17, 2026 08:35
@solracsf solracsf mentioned this pull request Aug 17, 2026
Merged
@moodyjmz

moodyjmz commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded by #63311, which fixes the same two spots (SystemConfig::DEFAULT_SENSITIVE_VALUES and AppConfig::getSensitiveKeys()) and adds regression tests for both — including the first unit test coverage SystemConfigTest has ever had. Appreciate you catching this independently and getting a fix up fast; #63311 just happened to land with test coverage for both leak paths (config.php vs the app's own settings page), so we're going with that one to avoid two PRs touching the same lines. Thanks for the report either way.

@moodyjmz moodyjmz closed this Aug 17, 2026
auto-merge was automatically disabled August 17, 2026 11:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: Eurooffice jwt_secret is exposed in system report

2 participants

@solracsf @moodyjmz